Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft; don't merge] v1 as frontend of v2 #2607

Draft
wants to merge 189 commits into
base: main
Choose a base branch
from
Draft

[Draft; don't merge] v1 as frontend of v2 #2607

wants to merge 189 commits into from

Conversation

darccio
Copy link
Member

@darccio darccio commented Mar 11, 2024

What does this PR do?

Turns the current v1 a frontend of v2, wrapping the new API while keeping the original behaviour.

Motivation

Simplify internal testing and future migration to v2.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

…ounterparts

Some functions have been adapted if v2 changed the API. Type aliases are the preferred way to convert types unless introducing an alias may leak v2 details.

We kept some types as they would expose v2 types, using manual conversion for these in the frontend functions that require them.

We kept as much tests as possible, but some were removed because they were asserting internal working no longer accessible, as v1 is an external user of v2.
…ir v2 counterparts

The original API is kept as is, wrapping around v2 equivalent code and configs, maintaining the behaviour expected by the package's tests.
…terparts

The conversion turned the API to a pure transparent frontend, with exported functions calling their v2 versions.
…parts

The conversion turned the API to a pure transparent frontend, with exported functions calling their v2 versions, including the types as v2 aliases.
The conversion turned the API to a pure transparent frontend, with exported functions calling their v2 versions.
…2 counterparts

The conversion turned the API to a pure transparent frontend, with exported functions calling their v2 versions.

Option types have been aliased, and contrib types have been used as wrappers to embed their v2 versions.
…ion for tests expecting v1's mocktracer.Span
darccio and others added 30 commits October 9, 2024 16:33
This reverts commit bd92328. Let's keep our v2 behavior and update the tests in dd-source to accomodate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants